[IMP] fs_attachment: simplify domain for attachment search by skipping res_field checks#585
Open
[IMP] fs_attachment: simplify domain for attachment search by skipping res_field checks#585
Conversation
Contributor
|
Hi @lmignon, |
…g res_field checks
CRogos
force-pushed
the
18.0-imp-ir_attachment-query
branch
from
9b29992 to
b0f48ca
Compare
CRogos
commented
Apr 1, 2026
Comment on lines
313
to
+320
| domain = [ | ||
| ("fs_storage_id", "in", self.ids), | ||
| "|", | ||
| ("res_field", "=", False), | ||
| ("res_field", "!=", False), | ||
| ] | ||
| attachments = self.env["ir.attachment"].search(domain) | ||
| attachments = ( | ||
| self.env["ir.attachment"] | ||
| .with_context(skip_res_field_check=True) | ||
| .search(domain) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Should be covered by this test:
https://github.com/oca/storage/blob/18.0/fs_attachment/tests/test_fs_storage.py#L245-L279
Contributor
|
LGTM bu should be tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lmignon what do you think on this change? Shouldn't this bypass this check as intended?
https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/models/ir_attachment.py#L531-L535
PS: I haven't tested it yet, therefor draft. Tests are green.